Skip to content

adding fabi.ai to clickhouse doc #3921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

adding fabi.ai to clickhouse doc #3921

wants to merge 4 commits into from

Conversation

zephyring
Copy link

Summary

Checklist

@zephyring zephyring requested review from a team as code owners June 9, 2025 20:32
@zephyring zephyring requested a review from slabko June 9, 2025 20:32
@vercel Vercel
Copy link

vercel bot commented Jun 9, 2025

@zephyring is attempting to deploy a commit to the ClickHouse Team on Vercel.

A member of the Team first needs to authorize it.

@CLAassistant
Copy link

CLAassistant commented Jun 9, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@vercel Vercel
Copy link

vercel bot commented Jun 9, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
clickhouse-docs-zh ⬜️ Ignored (Inspect) Visit Preview Jun 9, 2025 9:31pm

@Blargian
Copy link
Member

Hi @zephyring! Thanks for opening this PR.

Let's add

Fabi
Smartbook

as exceptions to the spelling list: https://github.com/fabi-ai/clickhouse-docs/blob/af9a97c6f72c425e2610565d0a8fed119bd6c5a2/scripts/aspell-ignore/en/aspell-dict.txt

You'll also need to add this page to a sidebar to get CI green and for the page to show:

clickhouse-docs/sidebars.js

Line 900 in b73232a

"integrations/data-visualization/zingdata-and-clickhouse",

@zephyring
Copy link
Author

Hi @zephyring! Thanks for opening this PR.

Let's add

Fabi
Smartbook

as exceptions to the spelling list: https://github.com/fabi-ai/clickhouse-docs/blob/af9a97c6f72c425e2610565d0a8fed119bd6c5a2/scripts/aspell-ignore/en/aspell-dict.txt

You'll also need to add this page to a sidebar to get CI green and for the page to show:

clickhouse-docs/sidebars.js

Line 900 in b73232a

"integrations/data-visualization/zingdata-and-clickhouse",

thanks for reviewing! I've added them

Blargian
Blargian requested changes Jun 15, 2025
View reviewed changes
Copy link
Member

@Blargian Blargian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one import statement missing and then we should be good to go

docs/integrations/data-visualization/fabi-and-clickhouse.md

import fabi_00 from '@site/static/images/integrations/data-visualization/fabi_00.png';
import fabi_01 from '@site/static/images/integrations/data-visualization/fabi_01.png';
import fabi_02 from '@site/static/images/integrations/data-visualization/fabi_02.png';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
import fabi_02 from '@site/static/images/integrations/data-visualization/fabi_02.png';
import fabi_02 from '@site/static/images/integrations/data-visualization/fabi_02.png';
import fabi_03 from '@site/static/images/integrations/data-visualization/fabi_03.png';

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Blargian Blargian Blargian requested changes

@slabko slabko Awaiting requested review from slabko slabko is a code owner automatically assigned from ClickHouse/integrations

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zephyring @CLAassistant @Blargian